Skip to content

Conversation

zas
Copy link
Collaborator

@zas zas commented Apr 23, 2025

The unfiltered mode was forced, use the default mode instead.

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Completer popup uses unfiltered mode, so it shows all choices in the popup, not limited to what's entered.

Solution

Use default QCompleter mode.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested review from phw and rdswift April 23, 2025 09:15
phw
phw previously approved these changes Apr 23, 2025
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this :)

Just for completeness, my previous comment on why this existed: #2635 (comment)

The unfiltered mode was forced, use the default mode instead.
@zas zas force-pushed the completer_mode branch from 884dcf3 to cfbedc9 Compare April 23, 2025 12:07
@zas zas merged commit 36014f0 into metabrainz:master Apr 23, 2025
51 checks passed
@zas zas deleted the completer_mode branch April 23, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants