PICARD-2192: Fix macos arm builds #2603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This harmonizes the builds between platforms
|
This time I actually was able to test run the build on an actual ARM64 mac. It works (and as expected launches faster than the Intel build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
Actually build on an arm64 runner. Previously the build pulled the x86_64 binaries for Qt6, which prevented the app to run. Also this way the code to test running the executable can be actually be run during build.
This also changes the install to use Python via actions/setup-python. This is consistent with other builds we have, and it fixes an issue with the system wide installation specifically on ARM refusing to install PyPI packages.
The builds actually should use a venv, but that's another story :D