Skip to content

Conversation

phw
Copy link
Member

@phw phw commented Mar 11, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

The tag editor removes tags which are not standard and store only a single empty value from the tag selection list. But this does not take into account tags where all values have been removed or where there are multiple empty values (which still counts as an empty tag in the end).

Solution

Check if the tag values are fully empty. Also some more refactoring.

@phw phw requested a review from zas March 11, 2025 06:06
@phw phw changed the title Fix empty tags being remove from tag selection Fix empty tags being removed from tag selection Mar 11, 2025
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit a27ad43 into metabrainz:master Mar 11, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants