Fix loading of folksonomy tags / genres #2573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zas
requested changes
Jan 8, 2025
- Save ~folksonomy_tags and ~genres as hidden variables - Fix merging tags from different levels - Fix excluding genre tags from ~folksonomy_tags
phw
force-pushed
the
fix_folksonomy_tags
branch
from
ec612f4 to
893c3ed
Compare
|
@zas I removed the print statement and added extended tests for the track genre handling. |
phw
force-pushed
the
fix_folksonomy_tags
branch
from
893c3ed to
8763d48
Compare
phw
force-pushed
the
fix_folksonomy_tags
branch
from
8763d48 to
d222b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
This is a follow up for #2545, which added the genre and folksonomy tags variables. During testing I found some issues with the behavior. The new variables were not properly created as hidden variables. Also the merging of variables from different levels was not applied consistently and setting the
genretag from the genre and folksonomy values was only fully applied on album reload.Solution
~folksonomy_tagsand~genresas hidden variables~folksonomy_tags