PICARD-3012: Sort files by disc no. when submitting cluster as release #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zas
requested changes
Jan 7, 2025
This ensures the disc numbers are in order even if the cluster gets edited after clustering.
phw
force-pushed
the
PICARD-3012-submit-cluster-sort-files
branch
from
d508438 to
6c43142
Compare
phw
force-pushed
the
PICARD-3012-submit-cluster-sort-files
branch
from
6c43142 to
7e34d9d
Compare
zas
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the disc numbers are in order even if the cluster gets edited after clustering.
Summary
Problem
When submitting a cluster as release the files inside the cluster are expected to be ordered by discnumber. Directly after clustering this is the case, but if files get added to the cluster later or if the discnumber tags on clustered files get edited, this is no longer true.
Since the consecutive indexing of submitted mediums relies on disc number changing to create a new disc this breaks.
Solution
Sort the files by discnumber when gathering the submission data.