Skip to content

Fix headers 2024 #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix headers 2024 #2571

merged 4 commits into from
Jan 7, 2025

Conversation

zas
Copy link
Collaborator

@zas zas commented Jan 7, 2025 •
edited
Loading

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw January 7, 2025 15:17
phw
phw approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zas: Looks good, LGTM.

Slightly related question, though: In #2560 it was suggested to drop the -*- coding: utf-8 -*- from the headers (since it is the default since Python 3.13). What's your opinion on this?

Doing this would also be done by adjusting the fix-headers script.

@zas
Copy link
Collaborator Author

zas commented Jan 7, 2025

See my answer about coding lines in #2560 (comment) (keep it for now).

@zas zas merged commit 02dab27 into metabrainz:master Jan 7, 2025
48 checks passed
@zas zas deleted the fix_headers_2024 branch January 7, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phw phw phw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zas @phw