Skip to content

Conversation

phw
Copy link
Member

@phw phw commented Dec 31, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

This makes use of @rdswift's recent settings changed signal (#2567) to handle updating the filenaming toggles in Options menu

Solution

Action

There are additionally issues with the profiles. When switching profiles via menu the toggles don't update accordingly. This issue is also present on the current 2.x release.

I started looking into this, but encountered additional profile issues on the master branch:

  1. Profile specific settings are not available directly after startup, hence the toggles don't show the settings properly. The profile groups are only properly initialized after the option dialog has been opened the first time. This is due to Move option declarations to picard/options.py and introduce const.defaults #2433 moving the initialization of profile groups to the option pages constructors.
  2. When opening the option dialog multiple times the settings in the profile configuration tree view duplicate each time.

I'll look into this in more detail in the new year. Because this is more complex I would like to keep this out of this more simple PR.

zas
zas previously approved these changes Dec 31, 2024
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw force-pushed the use-settings-changed-signal branch from 17d3c41 to e7a10c1 Compare January 1, 2025 10:51
zas
zas previously approved these changes Jan 1, 2025
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit e96f282 into metabrainz:master Jan 1, 2025
45 checks passed
@phw phw deleted the use-settings-changed-signal branch January 1, 2025 11:00
@phw phw mentioned this pull request Jan 1, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants