Skip to content

Conversation

YohayAiTe
Copy link
Contributor

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

When manually running scripts by right-clicking on a file and choosing "Run Scripts", Picard crashes. I could not find a JIRA ticket.

Solution

Initialised the tagger field in the ScriptsMenu class.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@YohayAiTe YohayAiTe changed the title added tagger instance to ScriptsMenu Fix run scripts manually Dec 28, 2024
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix.

No ticket is ok in this case as the release version is unaffected

@phw
Copy link
Member

phw commented Dec 28, 2024

@zas For some reason I can't approve the CI pipeline anymore. Also had this on another PR recently. Does it work for you?

@rdswift
Copy link
Collaborator

rdswift commented Dec 29, 2024

@zas For some reason I can't approve the CI pipeline anymore. Also had this on another PR recently. Does it work for you?

For some bizarre reason, I was able to approve the CI pipeline to run for this PR.

@phw phw merged commit cb84ea6 into metabrainz:master Dec 29, 2024
43 checks passed
@YohayAiTe YohayAiTe deleted the fix_run_script_manually branch December 29, 2024 10:58
@phw
Copy link
Member

phw commented Dec 29, 2024

@rdswift Thanks for running this. Not surprising, you became part of the Picard user group for fully managing the picard-docs repo, and that group has wide access to this repo, so you actually should be able to approve the CI runs. But so should I, and I don't get the necessary button anymore. Or maybe I just don't see it. It's really weird.

UPDATE: Figured it out: I seem to have some beta functionality with a new merge view enabled. And there the approve CI button seems to be missing (https://github.com/orgs/community/discussions/143787#discussioncomment-11679662). Unfortunately deactivating this beta function also fails for me :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants