Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion picard/ui/metadatabox.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ def __tag_ne(self, tag, orig, new):
else:
return orig != new

def is_readonly(self, tag):
return bool(self.status[tag] & TagStatus.READONLY)

def add(self, tag, orig_values, new_values, removable, removed=False, readonly=False, top_tags=None):
if orig_values:
self.orig.add(tag, orig_values)
Expand Down Expand Up @@ -235,6 +238,7 @@ def __init__(self, parent=None):
super().__init__(parent=parent)
self.tagger = QtCore.QCoreApplication.instance()
config = get_config()
config.setting.setting_changed_signal.connect(self._on_setting_changed)
self.setAccessibleName(_("metadata view"))
self.setAccessibleDescription(_("Displays original and new tags for the selected files"))
self.setColumnCount(3)
Expand Down Expand Up @@ -278,6 +282,10 @@ def __init__(self, parent=None):
self.ignore_updates = IgnoreUpdatesContext(on_exit=self.update)
self.tagger.clipboard().dataChanged.connect(self._update_clipboard)

def _on_setting_changed(self, key, old_value, new_value):
if key in ('rename_files', 'move_files'):
self.update(drop_album_caches=False)

def _get_file_lookup(self):
"""Return a FileLookup object."""
config = get_config()
Expand Down Expand Up @@ -624,6 +632,12 @@ def _update_tags(self, new_selection=True, drop_album_caches=False):

tag_diff.add('~length', str(orig_metadata.length), str(new_metadata.length),
removable=False, readonly=True)
if len(files) == 1:
if settings['rename_files'] or settings['move_files']:
new_filename = file.make_filename(file.filename, new_metadata)
else:
new_filename = file.filename
tag_diff.add('~filepath', [file.filename], [new_filename], removable=False, readonly=True)

for track in tracks:
if track.num_linked_files == 0:
Expand Down Expand Up @@ -708,7 +722,7 @@ def _update_items(self, result=None, error=None):
if not new_item:
new_item = QtWidgets.QTableWidgetItem()
new_item.setTextAlignment(alignment)
if tag == '~length':
if self.tag_diff.is_readonly(tag):
new_item.setFlags(orig_flags)
else:
new_item.setFlags(new_flags)
Expand Down
1 change: 1 addition & 0 deletions picard/util/tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
'encodedby': N_('Encoded By'),
'encodersettings': N_('Encoder Settings'),
'engineer': N_('Engineer'),
'~filepath': N_('File Path'),
'gapless': N_('Gapless Playback'),
'genre': N_('Genre'),
'grouping': N_('Grouping'),
Expand Down
Loading