Skip to content

Workaround for st_atime_ns == 0 on Linux / zfs / Python 3.12.3 #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Workaround for st_atime_ns == 0 on Linux / zfs / Python 3.12.3 #2549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions test/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,16 @@ def test_preserve_times(self):
# HERE an external access to the file is possible, modifying its access time

# read times again and compare with original
st = os.stat(self.file.filename)
max_tries = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment here explaining why this is necessary. This is so weird that we need to document it somehow.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to understand why it happens first.
Fixing the test is perhaps not enough...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

while max_tries:
self._read_testfile() # required
st = os.stat(self.file.filename)
if st.st_atime_ns > 0:
break
max_tries -= 1

self.assertTrue(max_tries > 0, "Max attempts to os.stat() attained!")

(after_atime_ns, after_mtime_ns) = (st.st_atime_ns, st.st_mtime_ns)

# on macOS 10.14 and later os.utime only sets the times with second
Expand All @@ -172,7 +181,7 @@ def test_preserve_times(self):
# access times may not be equal
# time difference should be positive and reasonably low (if no access in between, it should be 0)
delta = after_atime_ns - before_atime_ns
tolerance = 10**7 # 0.01 seconds
tolerance = 10**8 # 0.1 seconds
self.assertTrue(0 <= delta < tolerance, "0 <= %s < %s" % (delta, tolerance))

# ensure written data can be read back
Expand Down
Loading