Skip to content

Conversation

zas
Copy link
Collaborator

@zas zas commented Nov 5, 2024

…ig.config`

setting = {'enabled_plugins': []}, persist = None, profiles = None

    @staticmethod
    def set_config_values(setting=None, persist=None, profiles=None):
        if setting:
            for key, value in setting.items():
>               config.config.setting[key] = value
E               AttributeError: 'NoneType' object has no attribute 'setting'

test/picardtestcase.py:110: AttributeError

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

…ig.config`

```
setting = {'enabled_plugins': []}, persist = None, profiles = None

    @staticmethod
    def set_config_values(setting=None, persist=None, profiles=None):
        if setting:
            for key, value in setting.items():
>               config.config.setting[key] = value
E               AttributeError: 'NoneType' object has no attribute 'setting'

test/picardtestcase.py:110: AttributeError
```
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 5dab69b into metabrainz:master Nov 5, 2024
44 checks passed
@zas zas deleted the test_setup_call branch November 5, 2024 12:04
@zas zas mentioned this pull request Nov 6, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants