Skip to content

Commit 9395cdb

Browse files
committed
Only open edit tag dialog if there are tags to edit
Properly initialize `tag_diff` and check if it's `None`.
1 parent a78fcdc commit 9395cdb

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

picard/ui/metadatabox.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ def __init__(self, parent):
230230
self.files = set()
231231
self.tracks = set()
232232
self.objects = set()
233+
self.tag_diff = None
233234
self.selection_mutex = QtCore.QMutex()
234235
self.selection_dirty = False
235236
self.editing = None # the QTableWidgetItem being edited
@@ -456,7 +457,8 @@ def _apply_update_funcs(self, funcs):
456457
self.parent.update_selection(new_selection=False, drop_album_caches=True)
457458

458459
def edit_tag(self, tag):
459-
EditTagDialog(self.parent, tag).exec()
460+
if self.tag_diff is not None:
461+
EditTagDialog(self.parent, tag).exec()
460462

461463
def edit_selected_tag(self):
462464
tags = self.selected_tags(filter_func=self.tag_is_editable)

0 commit comments

Comments
 (0)