MetadataBox: use self as parent of QtGui.QAction actions

Author: zas

picard/ui/metadatabox.py

@@ -234,9 +234,9 @@ def __init__(self, parent):
         self.selection_dirty = False
         self.editing = None  # the QTableWidgetItem being edited
         self.clipboard = [""]
-        self.add_tag_action = QtGui.QAction(_("Add New Tag…"), parent)
+        self.add_tag_action = QtGui.QAction(_("Add New Tag…"), self)
         self.add_tag_action.triggered.connect(partial(self.edit_tag, ""))
-        self.changes_first_action = QtGui.QAction(_("Show Changes First"), parent)
+        self.changes_first_action = QtGui.QAction(_("Show Changes First"), self)
         self.changes_first_action.setCheckable(True)
         self.changes_first_action.setChecked(config.persist['show_changes_first'])
         self.changes_first_action.toggled.connect(self.toggle_changes_first)
@@ -366,18 +366,18 @@ def contextMenuEvent(self, event):
             if single_tag:
                 selected_tag = tags[0]
                 editable = self.tag_is_editable(selected_tag)
-                edit_tag_action = QtGui.QAction(_("Edit…"), self.parent)
+                edit_tag_action = QtGui.QAction(_("Edit…"), self)
                 edit_tag_action.triggered.connect(partial(self.edit_tag, selected_tag))
                 edit_tag_action.setShortcut(self.edit_tag_shortcut.key())
                 edit_tag_action.setEnabled(editable)
                 menu.addAction(edit_tag_action)
                 if selected_tag not in self.preserved_tags:
-                    add_to_preserved_tags_action = QtGui.QAction(_("Add to 'Preserve Tags' List"), self.parent)
+                    add_to_preserved_tags_action = QtGui.QAction(_("Add to 'Preserve Tags' List"), self)
                     add_to_preserved_tags_action.triggered.connect(partial(self.preserved_tags.add, selected_tag))
                     add_to_preserved_tags_action.setEnabled(editable)
                     menu.addAction(add_to_preserved_tags_action)
                 else:
-                    remove_from_preserved_tags_action = QtGui.QAction(_("Remove from 'Preserve Tags' List"), self.parent)
+                    remove_from_preserved_tags_action = QtGui.QAction(_("Remove from 'Preserve Tags' List"), self)
                     remove_from_preserved_tags_action.triggered.connect(partial(self.preserved_tags.discard, selected_tag))
                     remove_from_preserved_tags_action.setEnabled(editable)
                     menu.addAction(remove_from_preserved_tags_action)
@@ -393,7 +393,7 @@ def contextMenuEvent(self, event):
                                 values = self.tag_diff.orig[tag]
                             else:
                                 values = self.tag_diff.new[tag]
-                            lookup_action = QtGui.QAction(_("Lookup in &Browser"), self.parent)
+                            lookup_action = QtGui.QAction(_("Lookup in &Browser"), self)
                             lookup_action.triggered.connect(partial(self.open_link, values, tag))
                             menu.addAction(lookup_action)
                     if self.tag_is_removable(tag):
@@ -419,14 +419,14 @@ def contextMenuEvent(self, event):
                             objects = [album]
                             orig_values = list(album.orig_metadata.getall(tag)) or [""]
                             useorigs.append(partial(self.set_tag_values, tag, orig_values, objects))
-                remove_tag_action = QtGui.QAction(_("Remove"), self.parent)
+                remove_tag_action = QtGui.QAction(_("Remove"), self)
                 remove_tag_action.triggered.connect(partial(self._apply_update_funcs, removals))
                 remove_tag_action.setShortcut(self.remove_tag_shortcut.key())
                 remove_tag_action.setEnabled(bool(removals))
                 menu.addAction(remove_tag_action)
                 if useorigs:
                     name = ngettext("Use Original Value", "Use Original Values", len(useorigs))
-                    use_orig_value_action = QtGui.QAction(name, self.parent)
+                    use_orig_value_action = QtGui.QAction(name, self)
                     use_orig_value_action.triggered.connect(partial(self._apply_update_funcs, useorigs))
                     menu.addAction(use_orig_value_action)
                     menu.addSeparator()