-
-
Notifications
You must be signed in to change notification settings - Fork 109
Create re-convert_guillemets.py #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nero-A
wants to merge
4
commits into
metabrainz:2.0
Choose a base branch
from
Nero-A:patch-1
base: 2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
# Re-converts '«' and '»' (plugin for MusicBrainz Picard) | ||
# Copyright (C) 2019 Nero A. | ||
# | ||
# This program is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
||
|
||
PLUGIN_NAME = "re-convert" | ||
PLUGIN_AUTHOR = "Nero A." | ||
PLUGIN_DESCRIPTION = '''Re-converts \'«\' and \'»\'. | ||
The plugin is called "re-convert", because it's aim is to convert back characters/strings (to | ||
Unicode), after the internal converting from Unicode punctuation characters to ASCII in Picard.''' | ||
PLUGIN_VERSION = "0.1" | ||
PLUGIN_API_VERSIONS = ["2.0", "2.1", "2.2"] | ||
PLUGIN_LICENSE = "GPL-3.0-or-later" | ||
PLUGIN_LICENSE_URL = "https://gnu.org/licenses/gpl.html" | ||
|
||
|
||
# Converts characters/strings by other characters/string. | ||
# | ||
# The plugin is called "re-convert", because it's aim is to convert back characters/strings (to | ||
# Unicode), after the internal converting from Unicode punctuation characters to ASCII in Picard. | ||
# In concreto it will be used to re-convert "<<" (double less-than) and ">>" (double greater-than) | ||
# to "«" and "»" (guillemets, see https://en.wikipedia.org/wiki/Guillemet). | ||
# N.B. Currently only double guillemets will be re-converted but the plugin may be used for any | ||
# characters/strings and might be extended in future. | ||
# The converting will be done just straight forward, replace characters/strings by other | ||
# characters/string, without any further logic. This means there might also be "wrong" re-converts. | ||
# | ||
# The internal Unicode punctuation to ASCII converting in Picard converts several characters, | ||
# including double guillemets to double greater-than/less-than signs. | ||
# Since I'd like to keep double guillemets I will convert them back with this plugin. | ||
# | ||
# | ||
# See TAGS_ALBUM and TAGS_TRACK for affected metadata tags. | ||
|
||
|
||
from picard.metadata import register_album_metadata_processor | ||
from picard.metadata import register_track_metadata_processor | ||
|
||
|
||
REPLACE_TABLE = { | ||
# Punctuation: (double) guillemets | ||
"<<": "«", | ||
">>": "»", | ||
} | ||
|
||
TAGS_ALBUM = [ | ||
"album", | ||
"albumartist", | ||
"albumartistsort", | ||
"discsubtitle", | ||
"originalalbum", | ||
"originalartist", | ||
] | ||
|
||
TAGS_TRACK = [ | ||
"title", | ||
"artist", | ||
"artists", | ||
"artistsort", | ||
] | ||
|
||
|
||
def reconvert(value): | ||
result = value | ||
for key in REPLACE_TABLE: | ||
result = result.replace(key, REPLACE_TABLE[key]) | ||
|
||
return result | ||
|
||
|
||
def process_album(tagger, metadata, release): | ||
for name, value in metadata.rawitems(): | ||
if name in TAGS_ALBUM: | ||
metadata[name] = [reconvert(v) for v in value] | ||
|
||
|
||
def process_tracks(tagger, metadata, track, release): | ||
for name, value in metadata.rawitems(): | ||
if name in TAGS_TRACK: | ||
metadata[name] = [reconvert(v) for v in value] | ||
|
||
|
||
metadata.register_album_metadata_processor(process_album) | ||
metadata.register_track_metadata_processor(process_tracks) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title is too generic. It needs to be called something like "Convert guillemots" in order to explain to users what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to limit it to guillemots only. Maybe there will be more characters in future.
But maybe it's not worth to publish it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better for it to do something simple - and be well named.