Add output dir to top of all configs #2183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of our generation and eval configs don't match the format of our finetuning configs where the output_dir is at the top. This PR moves them to match the same format. It's a no-op for most configs touched here since output_dir is not used by generation or eval configs, but this way that's clear right at the top. The two configs that are not no-ops are early exit and quantization configs. This PR also helps ensure that
output_dir != checkpoint_dir
in all our configs. This is a constraint that we will now be enforcing so that we don't pollute HF's cached files with our finetuning artifactsScript to find the files to update:
Test plan:
Quantize recipe
Early exit recipe
Generate V2 recipe