-
Notifications
You must be signed in to change notification settings - Fork 678
output_dir not in ckpt dir #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2181
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit daec44b with merge base c6ddf11 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment, after that and green CI I think this is good to go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 66.58% 66.64% +0.06%
==========================================
Files 339 339
Lines 20064 20126 +62
==========================================
+ Hits 13359 13413 +54
- Misses 6705 6713 +8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Felipe Mello <felipemello@fb.com>
Co-authored-by: Felipe Mello <felipemello@fb.com>
Co-authored-by: Felipe Mello <felipemello@fb.com>
Co-authored-by: Felipe Mello <felipemello@fb.com>
Context
What is the purpose of this PR? Is it to
Changelog
As discussed, we wont allow output_dir to be the same or in ckpt_dir. Addresses #2173
Test plan
passes (output_dir != ckpt_dir)
fails (output_dir == ckpt_dir)