Skip to content

Conversation

felipemello1
Copy link
Contributor

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Changelog

As discussed, we wont allow output_dir to be the same or in ckpt_dir. Addresses #2173

Test plan

passes (output_dir != ckpt_dir)

tune run full_finetune_single_device --config llama3_2/3B_full_single_device 

fails (output_dir == ckpt_dir)

tune run full_finetune_single_device --config llama3_2/3B_full_single_device output_dir=/tmp/Llama-3.2-3B-Instruct/

Copy link

pytorch-bot bot commented Dec 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2181

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit daec44b with merge base c6ddf11 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2024
Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, after that and green CI I think this is good to go

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (c0b2cbd) to head (daec44b).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
torchtune/training/checkpointing/_checkpointer.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   66.58%   66.64%   +0.06%     
==========================================
  Files         339      339              
  Lines       20064    20126      +62     
==========================================
+ Hits        13359    13413      +54     
- Misses       6705     6713       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipemello1 felipemello1 merged commit 0528c11 into meta-pytorch:main Dec 19, 2024
17 checks passed
felipemello1 added a commit that referenced this pull request Dec 20, 2024
Co-authored-by: Felipe Mello <felipemello@fb.com>
mori360 pushed a commit to mori360/torchtune that referenced this pull request Dec 20, 2024
Co-authored-by: Felipe Mello <felipemello@fb.com>
rahul-sarvam pushed a commit to sarvamai/torchtune that referenced this pull request Dec 23, 2024
Co-authored-by: Felipe Mello <felipemello@fb.com>
rahul-sarvam pushed a commit to sarvamai/torchtune that referenced this pull request Dec 23, 2024
Co-authored-by: Felipe Mello <felipemello@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants