Skip to content

Fix excessive QAT warning #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix excessive QAT warning #2174

merged 1 commit into from
Dec 19, 2024

Conversation

andrewor14
Copy link
Contributor

Before:

>>> from torchtune.training.quantization import get_quantizer_mode, Int4WeightOnlyQATQuantizer
>>> get_quantizer_mode(Int4WeightOnlyQATQuantizer())
/data/users/andrewor/torchtune/torchtune/training/quantization.py:178: UserWarning: *QuantizerModuleSwap is deprecated. Please use the version without 'ModuleSwap' instead
  warn(
'4w-qat-module-swap'

After:

>>> from torchtune.training.quantization import get_quantizer_mode, Int4WeightOnlyQATQuantizer
>>> get_quantizer_mode(Int4WeightOnlyQATQuantizer())
'4w-qat'

@andrewor14
Fix excessive QAT warning
1a3a2fe 
Before:

```
>>> from torchtune.training.quantization import get_quantizer_mode, Int4WeightOnlyQATQuantizer
>>> get_quantizer_mode(Int4WeightOnlyQATQuantizer())
/data/users/andrewor/torchtune/torchtune/training/quantization.py:178: UserWarning: *QuantizerModuleSwap is deprecated. Please use the version without 'ModuleSwap' instead
  warn(
'4w-qat-module-swap'
```

After:

```
>>> from torchtune.training.quantization import get_quantizer_mode, Int4WeightOnlyQATQuantizer
>>> get_quantizer_mode(Int4WeightOnlyQATQuantizer())
'4w-qat'
```
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2174

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1a3a2fe with merge base 3518492 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2024
@andrewor14
Copy link
Contributor Author

@felipemello1 @ebsmothers

@andrewor14 andrewor14 mentioned this pull request Dec 18, 2024
Closed
@ebsmothers ebsmothers merged commit ff1fb6c into meta-pytorch:main Dec 19, 2024
17 checks passed
felipemello1 pushed a commit that referenced this pull request Dec 20, 2024
@andrewor14
Fix excessive QAT warning (#2174)
98a7a05
mori360 pushed a commit to mori360/torchtune that referenced this pull request Dec 20, 2024
@andrewor14 @mori360
Fix excessive QAT warning (meta-pytorch#2174)
384a7aa
rahul-sarvam pushed a commit to sarvamai/torchtune that referenced this pull request Dec 23, 2024
@andrewor14 @rahul-sarvam
Fix excessive QAT warning (meta-pytorch#2174)
52ed493
rahul-sarvam pushed a commit to sarvamai/torchtune that referenced this pull request Dec 23, 2024
@andrewor14 @rahul-sarvam
Fix excessive QAT warning (meta-pytorch#2174)
c42502f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joecummings joecummings joecummings approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewor14 @joecummings @facebook-github-bot @ebsmothers