Add ability to shard custom layers for DPO and LoRA distributed #2072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Addresses the concerns in #2071
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
Note in both cases that the memory when not sharded is higher than with sharded, confirming that this works.
WandB link for LoRA distributed: https://wandb.ai/jcummings/test-123
WandB link for DPO LoRA distributed: https://wandb.ai/jcummings/test-123-dpo
Configs
Testing for Qwen2.5 72B LoRA: https://wandb.ai/jcummings/qwen-sharding
Testing for Qwen2.5 32B LoRA: https://wandb.ai/jcummings/qwen2.5-32-sharding
Testing for Llama3 70B LoRA: https://wandb.ai/jcummings/llama3-sharded
(Llama3.1 70B LoRA was tested above)
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example