Skip to content

Conversation

mreso
Copy link
Contributor

@mreso mreso commented Aug 30, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?
Let's users create a custom instruct dataset with a custom system prompt without creating a custom dataset builder

Users can config their custom instruct dataset like:

# Dataset and Sampler
dataset:
  _component_: your.custom.folder.instruct_dataset
  source: "Samsung/samsum"
  train_on_input: False
  column_map:
    input: dialogue
    output: summary
  new_system_prompt: "Summarize the given text into a single sentence" # <<<----
  split: train

which previously required a custom builder function

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring: https://github.com/pytorch/torchtune/blob/6a7951f1cdd0b56a9746ef5935106989415f50e3/torchtune/modules/vision_transformer.py#L285
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models

  • I did not change any public API;
  • I have added an example to docs or docstrings;

Copy link

pytorch-bot bot commented Aug 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1465

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2303be0 with merge base 4fba6cd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (ec21546) to head (2303be0).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   70.01%   72.01%   +2.00%     
==========================================
  Files         268      272       +4     
  Lines       12937    13059     +122     
==========================================
+ Hits         9058     9405     +347     
+ Misses       3879     3654     -225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ebsmothers ebsmothers merged commit 4650ce6 into meta-pytorch:main Aug 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants