-
Notifications
You must be signed in to change notification settings - Fork 680
Move pooling from utils to training #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1455
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dda6622 with merge base dfc69e2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
- Coverage 70.01% 69.80% -0.22%
==========================================
Files 268 272 +4
Lines 12937 13053 +116
==========================================
+ Hits 9058 9111 +53
- Misses 3879 3942 +63 ☔ View full report in Codecov by Sentry. |
:toctree: generated/ | ||
:nosignatures: | ||
|
||
get_unmasked_sequence_lengths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: while you're here I actually think this should belong in rlhf/sequence_processing.py and for classification relevant utils to be refactored once we support classification tasks. not blocking on this, up to you.
Context
What is the purpose of this PR? Is it to
Addresses #1436 .
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring: https://github.com/pytorch/torchtune/blob/6a7951f1cdd0b56a9746ef5935106989415f50e3/torchtune/modules/vision_transformer.py#L285
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models