Skip to content

Conversation

RdoubleA
Copy link
Collaborator

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Addresses #1436 .

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring: https://github.com/pytorch/torchtune/blob/6a7951f1cdd0b56a9746ef5935106989415f50e3/torchtune/modules/vision_transformer.py#L285
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models

  • I did not change any public API;
  • I have added an example to docs or docstrings;

Copy link

pytorch-bot bot commented Aug 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1455

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dda6622 with merge base dfc69e2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
@RdoubleA RdoubleA changed the title move pooling Move pooling from utils to training Aug 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (ec21546) to head (54cbac4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
recipes/ppo_full_finetune_single_device.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   70.01%   69.80%   -0.22%     
==========================================
  Files         268      272       +4     
  Lines       12937    13053     +116     
==========================================
+ Hits         9058     9111      +53     
- Misses       3879     3942      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

:toctree: generated/
:nosignatures:

get_unmasked_sequence_lengths
Copy link
Contributor

@SalmanMohammadi SalmanMohammadi Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: while you're here I actually think this should belong in rlhf/sequence_processing.py and for classification relevant utils to be refactored once we support classification tasks. not blocking on this, up to you.

@RdoubleA RdoubleA merged commit 149bfeb into meta-pytorch:main Aug 31, 2024
20 checks passed
TeodorPoncu pushed a commit to TeodorPoncu/teds-torchtune that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants