Skip to content

Conversation

RdoubleA
Copy link
Collaborator

@RdoubleA RdoubleA commented Aug 29, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

As titled. We use max_seq_len from the tokenizer in all our datasets instead of an explicit parameter

Test plan

Tested with ds = text_completion_dataset(tokenizer=tokenizer, source="allenai/c4", column="text", data_dir="realnewslike", packed=False, split="train")

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring: https://github.com/pytorch/torchtune/blob/6a7951f1cdd0b56a9746ef5935106989415f50e3/torchtune/modules/vision_transformer.py#L285
Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models

  • I did not change any public API;
  • I have added an example to docs or docstrings;

Copy link

pytorch-bot bot commented Aug 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1453

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7bcbf2f with merge base c1e2d0d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2024
felipemello1
felipemello1 previously approved these changes Aug 29, 2024
@felipemello1 felipemello1 dismissed their stale review August 29, 2024 20:18

ci doesnt pass

@SalmanMohammadi
Copy link
Contributor

Think you gotta move max_seq_len=null from dataset to tokenizer in the Mistral 7B PPO config.

@RdoubleA RdoubleA merged commit 069bc4d into meta-pytorch:main Sep 3, 2024
20 checks passed
@RdoubleA RdoubleA deleted the fix_text_completion branch September 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants