Skip to content

Conversation

ramanishsingh
Copy link
Contributor

@ramanishsingh ramanishsingh commented Jan 10, 2025

Github is deprecating artifact actions v3.

Made the following changes:

actions/setup-python@v4 -> actions/setup-python@v5
actions/checkout@v3 -> actions/checkout@v4
actions/download-artifact@v3 -> actions/download-artifact@v4
actions/upload-artifact@v3 -> actions/upload-artifact@v4
refs:

  1. Upgrade actions/download-artifact@v4 pytorch/executorch#7573
  2. [BE] Update action versions pytorch/test-infra#5877

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@ramanishsingh ramanishsingh marked this pull request as draft January 10, 2025 18:39
Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1422

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures

As of commit a0ca3c3 with merge base 227d3d7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ramanishsingh ramanishsingh force-pushed the update_actions branch 2 times, most recently from 8d27f3d to a0ca3c3 Compare January 10, 2025 22:45
@ramanishsingh ramanishsingh marked this pull request as ready for review January 10, 2025 22:49
Copy link
Contributor

@andrewkho andrewkho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ramanish!

Copy link
Contributor

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :-)

@ramanishsingh ramanishsingh merged commit 4ec4548 into main Jan 13, 2025
64 of 90 checks passed
@andrewkho andrewkho deleted the update_actions branch January 14, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants