Skip to content

Fix build on windows-2022 and windows-2025 (visual studio 2022) #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

newinnovations
Copy link
Contributor

This PR fixes the problem (#138) of building mupdf with visual studio 2022 which is part of the windows-2022 and windows-2025 github runners.

@ginnyTheCat
Copy link
Collaborator

How is it possible that visual studio 2022 does not define NAN? Shouldn't that exist since C99, or is mupdf missing a include that we could upstream?

Copy link
Owner

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@messense messense merged commit ed1d471 into messense:main May 9, 2025
13 checks passed
@ginnyTheCat
Copy link
Collaborator

This seams to have been fixed in Windows 11, Build 10.0.26100.3916 but it's prolly gonna take a while for everybody to get the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants