wrap: Don't use patch.exe from Strawberry Perl #14795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirbheek
force-pushed
the
strawberry-patch
branch
from
e06866a to
7d1a8a8
Compare
eli-schwartz
requested changes
Jul 13, 2025
nirbheek
force-pushed
the
strawberry-patch
branch
3 times, most recently
from
089a062 to
3d6c471
Compare
|
So just to make sure I understand correctly, the issue with Strawberry Perl is that it uses GNU Patch but has a really out of date version that is known to be buggy? |
|
Not even buggy, just inadequate |
|
Yep, thanks for prodding me to look at the core issue. I verified that MSYS 1.0 has GNU patch 2.6.1 which works fine, and I think that's as old as we will encounter in the wild on Windows. |
eli-schwartz
approved these changes
Jul 18, 2025
It is too old and barfs on patches from git-format-patch: ``` Applying diff file "orc-0.4.38\0001-meson-fix-symbols-leaking-from-static-library-on-Win.patch" patching file meson.build Assertation failed! Program: C:\Strawberry\c\bin\patch.EXE File: .\src\patch\2.5.9\patch-2.5.9-src\patch.c, Line 354 Expression: hunk ``` 2.6.1 is the oldest known version that works correctly.
nirbheek
force-pushed
the
strawberry-patch
branch
from
3d6c471 to
2b1c200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It barfs on patches from git-format-patch: