Add support for BLAS and LAPACK dependencies (continued) #14773
+1,247
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2025
mgorny
force-pushed
the
dependency-openblas
branch
from
c2a41f4 to
08bec81
Compare
dcbaker
reviewed
Jul 17, 2025
|
Thanks for your comments. To be honest, I haven't gotten to cleaning up / modernizing the code yet — so far my main focus was getting it to work correctly :-). But pushed the suggested fixes now. |
mgorny
force-pushed
the
dependency-openblas
branch
3 times, most recently
from
de104e9 to
13b93a8
Compare
mgorny
force-pushed
the
dependency-openblas
branch
from
bfa9c78 to
c4f4671
Compare
|
Okay, I think this is ready for review. FWIU the "linux" test failures are due to the test images not being updated — and the Ubuntu image failure is flakiness of the zig version check. |
jpakkane
reviewed
Jul 24, 2025
| keyword, with possible values: | ||
|
|
||
| - `'interface: lp64'` (default) or `'interface: ilp64'`: to select the default | ||
| integer size |
There was a problem hiding this comment.
I understand why you did this, but it's conceptually not really correct. An "interface" is not really a module. Could we have some other way of expressing this information that is more explicit about what it does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a rebase / continuation of #10921.
So far just gotten it to work again, will look through the previous review next.