-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support sftp in wrap file #14772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ampleyfly
wants to merge
4
commits into
mesonbuild:master
Choose a base branch
from
ampleyfly:support-sftp-in-wrap-file-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support sftp in wrap file #14772
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3d4b313
wrap: Slightly improve error message on wrap get failure
ampleyfly ac0e22b
wrap: Break out hash_file() function
ampleyfly 419a968
wrap: Add basic sftp support to wrap.get_data()
ampleyfly e9e361c
test cases: Add test case for wrap-file with sftp
ampleyfly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code that fiddles with the end user's crypto setup makes me especially anxious. If you set these arguments in the wrap file, then that file can only work on the machine it has been generated on (or en exact replica of it). There might also be some sort of a information leakage vulnerability here, but I don't have the skills to say so one way or another.
Because of these and similar reasons we try to stay away from access control as much as possible. Are these features absolutely necessary or can we just say "set up access control outside Meson"?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternatives for testing the SSH part is authentication with either a key pair (which is generated in each run here), or a password (meaning we need to have a test user with a known password).
The intention was not that "source_identityfile" should be used outside of testing, as indicated by the commit message. If there's a better way to inject the necessary information into the code, for test purposes only, I'm open to suggestions.
Alternatives for the testing as a whole might be to:
a) skip SSH, just do the SFTP part (this would still require the code under test to know to connect in a different way, afaict), or
b) skip testing altogether.
EDIT: RE the crypto setup comment: In case it wasn't clear, the code does not modify the user's crypto configuration. It does, however, allow the user to specify a host public key and the path to a client identity file to use for the SFTP call. Again, this was done for testing purposes, so another way of accomplishing it would be nice.