-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
new custom dependency lookup for libexecinfo #14753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
just noticed no BSD CIs. Unfortunate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about this a few times too, so I'm happy to have it.
We should probably note somewhere that CMake's equivalent is called backtrace
If CMake's equivalent is called backtrace , we should match it here. |
8035995
to
03fcacb
Compare
The only concern I have with that is that there is a libbacktrace. They don't currently provide a pkg-config file (and it doesn't look like any of the distros patch one it, but it seems like a potential for a conflict. I think CMake made the wrong decision 15 years ago, and I don't think we should replicate it. If someone creates a |
OK. |
Given everyone packaging this calls it libexecinfo it's plain we shouldn't call it "backtrace" -- a function name rather than a header + BSD library name. And for some extra fun: https://github.com/fam007e/libexecinfo Nobody uses it, author self-uploaded to the AUR. :P Does provide a pkg-config file called... libexecinfo.pc We will never use |
I think it's worth mentioning in the documentation that CMake provides the same functionality as
So I guess we should provide pkg-config support as well? I'd be in favor of making that the last checked method. |
OK done. |
... maybe? I have mixed feelings about it if it's going to have zero known users. The one place it can be found is a glibc-only distro. Initial commit is last month. |
The issue I have with the pkgconfig solution is that it's redundant. The system one will find it. Its pkgconfig file has the base include directory specified. |
That's only true if you configure the package with PREFIX=/ and not some other path, right? |
In particular, nixos has a derivation for libexecinfo, and I wouldn't find it with the .pc file |
ah right. |
@dcbaker are you packaging this brand new greenfield project from a month ago, for nixos? |
I was curious https://repology.org/project/libexecinfo/packages the only usage of that libexecinfo is the AUR. |
@eli-schwartz: nope, apparently nixos packages the freebsd implementation under that name |
That's why I asked you if you were going to do it. ;) As I said above -- currently nobody packages it at all, other than
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's fine. These polyfill libraries have a bunch of issues but this one is less problematic than the others in that the naming is consistent, I think.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Basically copy/paste from the iconv dependency.