rewriter: allow reading dict-valued kwargs; improve key-value pairs in CLI; minor improvements #14740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project ID must be "/" and cannot be an arbitrary string.
Fixes: e81acbd ("Use a single coredata dictionary for options")
Many rewriter subcommands expect key/value pairs as adjacent arguments. If the last value is missing, show a user-friendly error instead of a backtrace. For: mesonbuild#13234
The `default-options delete` and `kwargs delete` subcommands required key/value pairs, where the key was deleted and the specified value was ignored. This matches the JSON script mode interface but is unpleasant as a CLI. Since the UI is documented to be unstable, we can change this. Have the CLI `delete` commands accept a list of keys instead. Fixes: mesonbuild#13234
We can't modify dict-valued kwargs (mesonbuild#14739) but this lets us at least read them.
|
Fixes: #14739 |
|
@bonzini Nope, this PR allows reading dict-valued kwargs but not writing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargs infofor dict-valued kwargs. We can't modify these yet but it's useful to be able to read them.default-options deleteandkwargs deletesubcommands required key/value pairs, where the key was deleted and the specified value was ignored. This matches the JSON script mode interface but is unpleasant as a CLI. Since the UI is documented to be unstable, we can change this. Have the CLIdeletecommands accept a list of keys instead.meson rewrite kwargs delete project / <option>raises unhandled exception unless a dummy second value is passed #13234meson rewrite kwargs delete project / <option>raises unhandled exception unless a dummy second value is passed #13234license_fileskwarg toproject().