Skip to content

MAINT: avoid warnings because of symlinks pointing outside repo #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgommers
Copy link
Contributor

@rgommers rgommers commented May 5, 2025

Follows up on #728 (comment) and gh-745.

@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label May 5, 2025
@rgommers rgommers force-pushed the distscript-sdist-warnings branch from fa269c5 to ebe7411 Compare May 5, 2025 12:44
@rgommers rgommers added this to the v0.19.0 milestone May 22, 2025
Copy link
Member

@dnicolodi dnicolodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to create the symlinks in the test code. This is simpler, but should we add a note in the test somewhere stating that these test files are not present in the sdist?

@rgommers rgommers force-pushed the distscript-sdist-warnings branch from ebe7411 to 5915072 Compare July 15, 2025 10:27
@rgommers
Copy link
Contributor Author

Another solution would be to create the symlinks in the test code. This is simpler, but should we add a note in the test somewhere stating that these test files are not present in the sdist?

I prefer this, both because it's simpler and because I regularly use test packages directly rather than via a pytest invocation, so I prefer it if they were complete without dynamic additions.

@rgommers
Copy link
Contributor Author

Added the note in the test case itself, that is indeed useful.

@rgommers
Copy link
Contributor Author

CI failure is unrelated, looks like a change in Meson master:

FAILED tests/test_editable.py::test_mesonpy_meta_finder - AssertionError: assert 'D:/a/meson-python/meson-python/tests/packages/complex/complex\\__init__.py' == 'D:\\a\\meson-python\\meson-python\\tests\\packages\\complex\\complex\\__init__.py'
  
  - D:\a\meson-python\meson-python\tests\packages\complex\complex\__init__.py
  ?   ^ ^            ^            ^     ^        ^       ^
  + D:/a/meson-python/meson-python/tests/packages/complex/complex\__init__.py
  ?   ^ ^            ^            ^     ^        ^       ^
FAILED tests/test_editable.py::test_importlib_resources - AssertionError: assert 'D:/a/meson-python/meson-python/tests/packages/simple/__init__.py' == 'D:\\a\\meson-python\\meson-python\\tests\\packages\\simple\\__init__.py'

@eli-schwartz
Copy link
Member

mesonbuild/meson#12194 probably.

@dnicolodi
Copy link
Member

mesonbuild/meson#12194 probably

Most likely. That patch changes the format of the introspection data used by meson-python. So far meson-python assumes that the introspection data uses native path separators. Now, some data uses native path separators, and some uses POSIX path separators independently of the platform. For supporting Meson version before and after the change, meson-python will need to normalize all paths read from introspection data.

@rgommers
Copy link
Contributor Author

I opened gh-778 to keep track of the new failure. This PR is ready to merge I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular code improvements that are not new features nor end-user-visible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants