Fix rak11310 Voltage Read #6618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add voltage read correction for rak11310
fifieldt
changed the title
caveman99
requested changes
Apr 19, 2025
| #if defined(RAK11310) | ||
| float voltage_raw = operativeAdcMultiplier * ((1000 * AREF_VOLTAGE) / 1023) * raw; | ||
|
|
||
| LOG_INFO("[POWER DEBUG] AREF=%.2fV, ADC_RAW=%u, ADC_MULT=%.2f", |
There was a problem hiding this comment.
Please don't log an info called 'DEBUG' :-)
|
|
||
| scaled = (voltage_raw * 1.22f) - 0.1f; | ||
| scaled = operativeAdcMultiplier * ((1000 * AREF_VOLTAGE) / 4096) * raw; | ||
| LOG_INFO("[POWER CORRECTION] Before=%.2fmV, After=%.2fmV", |
There was a problem hiding this comment.
Please drop the [POWER CORRECTION] - Log lines will be auto-prefixed with the thread name.
| (double)operativeAdcMultiplier); | ||
|
|
||
| scaled = (voltage_raw * 1.22f) - 0.1f; | ||
| scaled = operativeAdcMultiplier * ((1000 * AREF_VOLTAGE) / 4096) * raw; |
There was a problem hiding this comment.
you are computing scaled twice here. either the latter is in here by mistake or you can drop the former one.
| raw, | ||
| (double)operativeAdcMultiplier); | ||
|
|
||
| scaled = (voltage_raw * 1.22f) - 0.1f; |
There was a problem hiding this comment.
1.22f seems to be a correction factor. can we make this a generic correction macro and remove the #ifdef bracket? In case we need it on more than the 11310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add voltage read correction for rak11310
🙏 Thank you for sending in a pull request, here's some tips to get started!
❌ (Please delete all these tips and replace them with your text) ❌
to say "Hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback
is appreciated." This will allow other devs to potentially save you time by not accidentially duplicating work etc...
because it automatically follows our indentation rules and its auto reformatting will not cause spurious changes to lines.
🤝 Attestations