Skip to content

Disconnect swipe #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2025
Merged

Disconnect swipe #1191

merged 5 commits into from
May 21, 2025

Conversation

RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Apr 27, 2025

What changed?

Add animation to demo swipe to disconnect on first connection.

Why did it change?

Users do not understand that it is possible to swipe left on a node, this brings it to their attention more prominently.

How is this tested?

Tested on my iPhone.

Screenshots/Videos (when applicable)

ScreenRecording_04-01-2025_22-22-35_1.mov

I also added a disconnect long press action to allow another way for users to disconnect in case they have not discovered the swipe.
IMG_3446
Also added an App Intent and Siri phrases to disconnect a node
IMG_3451

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require an update to existing documentation or if new documentation is needed, and created an issue in the docs repo if applicable.
  • I have tested the change to ensure that it works as intended.

@garthvh
Copy link
Member

garthvh commented May 3, 2025

The animation is just not necessary, the long press button is fine.

@RCGV1
Copy link
Member Author

RCGV1 commented May 3, 2025

The animation only happens in your first ever connection, not going to get annoying just to teach people

@RCGV1
Copy link
Member Author

RCGV1 commented May 16, 2025

I removed the animation and instead made the swipe to disconnect bold in tips
IMG_3780

@RCGV1 RCGV1 requested a review from garthvh May 16, 2025 23:35
@garthvh garthvh changed the base branch from main to 2.6.3 May 21, 2025 02:22
@garthvh garthvh merged commit 45f7aed into 2.6.3 May 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants