chore: change replicator to access

florianow · florianow · commit 88fc6ed79457 · 2025-04-15T13:52:49.000+02:00
chore: adding default value for scp deployment
diff --git a/README.md b/README.md
@@ -97,7 +97,7 @@ After applying the configuration, you can retrieve the following outputs using `
 | <a name="input_replicator_enabled"></a> [replicator\_enabled](#input\_replicator\_enabled) | n/a | `bool` | `true` | no |
 | <a name="input_scope"></a> [scope](#input\_scope) | The scope of the service principal. The scope is usually the id of the aks subscription | `string` | n/a | yes |
 | <a name="input_service_principal_name"></a> [service\_principal\_name](#input\_service\_principal\_name) | Display name of the replicator service principal. | `string` | n/a | yes |
-| <a name="input_workload_identity_federation"></a> [workload\_identity\_federation](#input\_workload\_identity\_federation) | Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack. | `object({ issuer = string, replicator_subject = string })` | `null` | no |
+| <a name="input_workload_identity_federation"></a> [workload\_identity\_federation](#input\_workload\_identity\_federation) | Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack. | `object({ issuer = string, access_subject = string })` | `null` | no |
 
 ## Outputs
 
diff --git a/main.tf b/main.tf
@@ -12,8 +12,8 @@ module "replicator_service_principal" {
   service_principal_name = var.service_principal_name
   create_password        = var.create_password
   workload_identity_federation = var.workload_identity_federation == null ? null : {
-    issuer             = var.workload_identity_federation.issuer,
-    replicator_subject = var.workload_identity_federation.replicator_subject
+    issuer         = var.workload_identity_federation.issuer,
+    access_subject = var.workload_identity_federation.access_subject
   }
   application_owners = var.application_owners
 }
diff --git a/modules/meshcloud-replicator-service-principal/README.md b/modules/meshcloud-replicator-service-principal/README.md
@@ -34,7 +34,7 @@ No modules.
 | <a name="input_create_password"></a> [create\_password](#input\_create\_password) | Create a password for the enterprise application. | `bool` | n/a | yes |
 | <a name="input_scope"></a> [scope](#input\_scope) | The scope of the service principal. The scope is usually the id of the aks subscription | `string` | n/a | yes |
 | <a name="input_service_principal_name"></a> [service\_principal\_name](#input\_service\_principal\_name) | Display name of the replicator service principal. | `string` | `null` | no |
-| <a name="input_workload_identity_federation"></a> [workload\_identity\_federation](#input\_workload\_identity\_federation) | Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack. | `object({ issuer = string, replicator_subject = string })` | `null` | no |
+| <a name="input_workload_identity_federation"></a> [workload\_identity\_federation](#input\_workload\_identity\_federation) | Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack. | `object({ issuer = string, access_subject = string })` | `null` | no |
 
 ## Outputs
 
diff --git a/modules/meshcloud-replicator-service-principal/auth.tf b/modules/meshcloud-replicator-service-principal/auth.tf
@@ -36,5 +36,5 @@ resource "azuread_application_federated_identity_credential" "meshcloud_replicat
   display_name   = var.service_principal_name
   audiences      = ["api://AzureADTokenExchange"]
   issuer         = var.workload_identity_federation.issuer
-  subject        = var.workload_identity_federation.replicator_subject
+  subject        = var.workload_identity_federation.access_subject
 }
diff --git a/modules/meshcloud-replicator-service-principal/variables.tf b/modules/meshcloud-replicator-service-principal/variables.tf
@@ -12,7 +12,7 @@ variable "create_password" {
 variable "workload_identity_federation" {
   default     = null
   description = "Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack."
-  type        = object({ issuer = string, replicator_subject = string })
+  type        = object({ issuer = string, access_subject = string })
 }
 
 variable "application_owners" {
diff --git a/variables.tf b/variables.tf
@@ -54,7 +54,7 @@ variable "create_password" {
 variable "workload_identity_federation" {
   default     = null
   description = "Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack."
-  type        = object({ issuer = string, replicator_subject = string })
+  type        = object({ issuer = string, access_subject = string })
 }
 
 variable "application_owners" {

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@ module "replicator_service_principal" {`
`12`	`12`	`service_principal_name = var.service_principal_name`
`13`	`13`	`create_password = var.create_password`
`14`	`14`	`workload_identity_federation = var.workload_identity_federation == null ? null : {`
`15`		`- issuer = var.workload_identity_federation.issuer,`
`16`		`- replicator_subject = var.workload_identity_federation.replicator_subject`
	`15`	`+ issuer = var.workload_identity_federation.issuer,`
	`16`	`+ access_subject = var.workload_identity_federation.access_subject`
`17`	`17`	`}`
`18`	`18`	`application_owners = var.application_owners`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,5 @@ resource "azuread_application_federated_identity_credential" "meshcloud_replicat`
`36`	`36`	`display_name = var.service_principal_name`
`37`	`37`	`audiences = ["api://AzureADTokenExchange"]`
`38`	`38`	`issuer = var.workload_identity_federation.issuer`
`39`		`- subject = var.workload_identity_federation.replicator_subject`
	`39`	`+ subject = var.workload_identity_federation.access_subject`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ variable "create_password" {`
`12`	`12`	`variable "workload_identity_federation" {`
`13`	`13`	`default = null`
`14`	`14`	`description = "Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack."`
`15`		`- type = object({ issuer = string, replicator_subject = string })`
	`15`	`+ type = object({ issuer = string, access_subject = string })`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`variable "application_owners" {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ variable "create_password" {`
`54`	`54`	`variable "workload_identity_federation" {`
`55`	`55`	`default = null`
`56`	`56`	`description = "Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack."`
`57`		`- type = object({ issuer = string, replicator_subject = string })`
	`57`	`+ type = object({ issuer = string, access_subject = string })`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`variable "application_owners" {`