chore: adding default value for scp deployment

chore: adding default value for scp deployment

Author: florianow

main.tf

@@ -6,7 +6,7 @@ resource "kubernetes_namespace" "meshcloud" {
 }
 
 module "replicator_service_principal" {
-  count                  = var.replicator_enabled ? 1 : 0
+  count                  = var.replicator_enabled || var.service_principal_name != null ? 1 : 0
   scope                  = var.scope
   source                 = "./modules/meshcloud-replicator-service-principal"
   service_principal_name = var.service_principal_name

modules/meshcloud-replicator-service-principal/README.md

@@ -33,7 +33,7 @@ No modules.
 | <a name="input_application_owners"></a> [application\_owners](#input\_application\_owners) | List of user principals that should be added as owners to the replicator service principal. | `list(string)` | `[]` | no |
 | <a name="input_create_password"></a> [create\_password](#input\_create\_password) | Create a password for the enterprise application. | `bool` | n/a | yes |
 | <a name="input_scope"></a> [scope](#input\_scope) | The scope of the service principal. The scope is usually the id of the aks subscription | `string` | n/a | yes |
-| <a name="input_service_principal_name"></a> [service\_principal\_name](#input\_service\_principal\_name) | Display name of the replicator service principal. | `string` | n/a | yes |
+| <a name="input_service_principal_name"></a> [service\_principal\_name](#input\_service\_principal\_name) | Display name of the replicator service principal. | `string` | `null` | no |
 | <a name="input_workload_identity_federation"></a> [workload\_identity\_federation](#input\_workload\_identity\_federation) | Enable workload identity federation instead of using a password by providing these additional settings. Usually you should receive the required settings when attempting to configure a platform with workload identity federation in meshStack. | `object({ issuer = string, replicator_subject = string })` | `null` | no |
 
 ## Outputs

modules/meshcloud-replicator-service-principal/variables.tf

@@ -1,5 +1,6 @@
 variable "service_principal_name" {
   type        = string
+  default     = null
   description = "Display name of the replicator service principal."
 }
 

outputs.tf

@@ -1,6 +1,6 @@
 ## METERING
 output "metering_token" {
-  value     = module.meshcloud-service-account-meshfed-metering.0.token_metering
+  value     = length(module.meshcloud-service-account-meshfed-metering) > 0 ? module.meshcloud-service-account-meshfed-metering[0].token_metering : null
   sensitive = true
 }
 
@@ -12,7 +12,7 @@ output "metering_expose_token" {
 ## REPLICATOR
 
 output "replicator_token" {
-  value     = module.meshcloud-service-account-meshfed-replicator.0.token_replicator
+  value     = length(module.meshcloud-service-account-meshfed-replicator) > 0 ? module.meshcloud-service-account-meshfed-replicator[0].token_replicator : null
   sensitive = true
 }