Skip to content

Fix for Dockerfile smell DL3025 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Fix for Dockerfile smell DL3025

8549dce
Select commit
Loading
Failed to load commit list.
Open

Fix for Dockerfile smell DL3025 #708

Fix for Dockerfile smell DL3025
8549dce
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Dec 10, 2024 in 0s

2/4 Fail(s): TITLE, APPROVALS

Status: FAIL

    Here are some stats of the run:
    4 validations were ran.
    2 PASSED
    2 FAILED

Details

❌ Validator: TITLE

  • ❌ Semantic release conventions must be followed.
    Input : Fix for Dockerfile smell DL3025
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|refactor|test|style|perf)(\\(\\w+\\))?:.+$","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '[ ]'
    Input : Hi!
    The Dockerfile placed at "Dockerfile" contains the best practice violation DL3025 detected by the hadolint tool.

The smell DL3025 occurs if the JSON notation is not used for the arguments of CMD and ENTRYPOINT instructions.
This pull request proposes a fix for that smell generated by my fixing tool. The patch was manually verified before opening the pull request. To fix this smell, specifically, the command arguments are refactored in the JSON notation format.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

   Settings : ```{"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}```

❌ Validator: APPROVALS

  • ✔️ approvals does have a minimum of '1'
    Input : invisiblepancake
    Settings : {"min":{"count":1}}
  • ❌ (approvals: jusx required OR approvals: shine2lay required)
    Input : invisiblepancake
    Settings : {"or":[{"required":{"reviewers":["jusx"]}},{"required":{"reviewers":["shine2lay"]}}]}

✔️ Validator: OR

  • ❌ Option 1: And: Option 1: title: title does not include "^(feat|fix)((\w+))?:.+$"
    Input : Fix for Dockerfile smell DL3025
    Settings : {"must_include":{"regex":"^(feat|fix)(\\(\\w+\\))?:.+$"}}
  • ❌ Option 1: And: Option 2: changeset: new features or fixes needed to be logged to the changelog
    Input : Dockerfile
    Settings : {"must_include":{"regex":"docs/changelog.rst","message":"new features or fixes needed to be logged to the changelog"}}
  • ✔️ Option 2: title: title must exclude '^(feat|fix)((\w+))?:.+$'
    Input : Fix for Dockerfile smell DL3025
    Settings : {"must_exclude":{"regex":"^(feat|fix)(\\(\\w+\\))?:.+$","message":"new features or fixes needed to be logged to the changelog"}}
View more details on Mergeable