Skip to content

feat: custom pubsub with custom args on subscribe method #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

simone-sanfratello
Copy link
Contributor

This PR wants to add the capability to have custom params on subscribe method using a CustomPubSub implementation. This is useful in case you need to get an argument from the subscription method

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jonnydgreen May 6, 2025 15:10
Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks good to me! Is it worth updating the typings and type tests as well? wdyt? :)

Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcollina mcollina merged commit 1500b25 into mercurius-js:master May 7, 2025
7 checks passed
@simone-sanfratello simone-sanfratello deleted the feat/custom-pubsub-custom-args branch May 7, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants