feat: improve reconcile and add status conditions on all api objects #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

rafalgalaw wants to merge 27 commits into main from feat-improve-reconcile-updates

Collaborator

rafalgalaw commented Apr 2, 2025

No description provided.

rafalgalaw force-pushed the feat-improve-reconcile-updates branch from f36ed0e to b46241f Compare

April 2, 2025 17:52

rafalgalaw changed the title ~~Improve and cleanup Reconcile() updates~~ feat: improve reconcile and add status conditions on all api objects

rafalgalaw marked this pull request as ready for review

August 29, 2025 13:56

rafalgalaw requested review from H777K, bavarianbidi and maigl as code owners

August 29, 2025 13:56

rafalgalaw force-pushed the feat-improve-reconcile-updates branch from 8559d8b to c50d045 Compare

August 29, 2025 13:58

bavarianbidi reviewed

View reviewed changes

Member

bavarianbidi left a comment

Can we please discuss the runner condition introduction - would like to move this to a future version

api/v1beta1/runner_types.go Outdated Show resolved Hide resolved

internal/controller/enterprise_controller.go Show resolved Hide resolved

pkg/conditions/condition_types.go Outdated Show resolved Hide resolved

pkg/conditions/condition_types.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/enterprise_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/enterprise_controller.go Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/garmserverconfig_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/githubcredentials_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/enterprise_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/githubendpoint_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/organization_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/organization_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/pool_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/repository_controller.go Outdated Show resolved Hide resolved

bavarianbidi reviewed

View reviewed changes

internal/controller/repository_controller.go Outdated Show resolved Hide resolved

bavarianbidi requested changes

View reviewed changes

Member

bavarianbidi left a comment

Hey @rafalgalaw,

thanks for this great PR ... this improves the readability a lot and it also makes the different controllers more consistent.
just some small nits in the controller implementations.

But my biggest concern is the introduction of conditions in the runner CRD. It's definetly a nice improvement but I do not want to break the already released API.

bavarianbidi added this to the release v0.5 milestone

rafalgalaw added 9 commits

November 4, 2025 13:26


          feat: initialize conditions to unknown and move status updates to def…

05e4296

…er func


          fix: add missing error events

fcb58c5


          fix: implement ConditionStatusObject interface on all API objects

46d41c1


          feat: improve garmserverconif controller status updates

9f5d864


          feat: improve githubcredentials controller status updates

d9d7f6a


          feat: improve githubendpoint controller status updates

05cc4db


          fix: cleanup image_types.go

c5c5687


          feat: improve pool controller status updates

98fd1eb


          feat: improve runner controller sync

rafalgalaw added 16 commits

November 4, 2025 13:29


          fix: improve runner controller performance

2a9d4c9


          fix: rename conditions and add status messages

eb2fdef


          fix: runner controller status conditions

2827af4


          fix: enterprise controller tests

4d35615


          fix: garmserverconfig_controller tests

5976f74


          fix: organization_controller tests

23a8549


          fix: repository_controller tests

b3e21cb


          fix: runner_controller tests

b1415a3


          chore: fix go lint

0dc473e


          fix(runner): remove conditions for now

800be3c


          fix(controller): remove depricated ctrl.Result{Requeue: true} and uns…

df30b7e

…used named return vars


          fix(controller): rename initial CR var

68fbe63


          fix(conditions): cleanup

771f533


          fix(enterprise): simplify Reconcile method

e284bd7


          fix(organization): simplify Reconcile method

76a9199


          fix(repository): simplify Reconcile method

rafalgalaw force-pushed the feat-improve-reconcile-updates branch from 37984a9 to 9099287 Compare

November 4, 2025 13:04

rafalgalaw added 2 commits

November 4, 2025 14:14


          chore: bump go to 1.24.9

1fc532c


          chore: remove nancy scan

271ba3e

rafalgalaw force-pushed the feat-improve-reconcile-updates branch from ecfb34f to 271ba3e Compare

November 4, 2025 13:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet