Loading Concept Reference Range Configurations #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wikumChamith
changed the title
wikumChamith
force-pushed
the
TRUNK-6264
branch
2 times, most recently
from
2a87d27 to
98370cf
Compare
dkayiwa
reviewed
Dec 11, 2024
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.beans.factory.annotation.Qualifier; | ||
|
|
||
| class ConceptReferenceRangeLoaderIntegrationTest extends DomainBaseModuleContextSensitiveTest { |
wikumChamith
force-pushed
the
TRUNK-6264
branch
from
98370cf to
614e0e2
Compare
ibacher
reviewed
Dec 12, 2024
wikumChamith
force-pushed
the
TRUNK-6264
branch
3 times, most recently
from
7e979fa to
34a830c
Compare
wikumChamith
force-pushed
the
TRUNK-6264
branch
from
34a830c to
150d3a1
Compare
wikumChamith
changed the title
mks-d
requested changes
Jan 6, 2025
There was a problem hiding this comment.
@wikumChamith thanks for your initiative and work on this.
Could you however edit your PR description here and detail what this PR brings?
Ruhanga
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Overall, it's looking good @wikumChamith. Just a reminder to conditionally load the api-2.7 packages through the config.xml file in the omod sub-module's resources. Here's another minor concern to consider.
api/src/test/java/org/openmrs/module/initializer/DomainBaseModuleContextSensitiveTest.java
Outdated
Show resolved
Hide resolved
ibacher
reviewed
Jan 6, 2025
...openmrs/module/initializer/api/conceptreferencerange/ConceptReferenceRangeLineProcessor.java
Outdated
Show resolved
Hide resolved
| @Component | ||
| public class ConceptReferenceRangeLineProcessor extends BaseLineProcessor<ConceptReferenceRange> { | ||
|
|
||
| private final String HEADER_CONCEPT_NUMERIC_UUID = "Concept Numeric UUID"; |
There was a problem hiding this comment.
And so on throughout. I think this is more consistent with how things are done:
Suggested change
| private final String HEADER_CONCEPT_NUMERIC_UUID = "Concept Numeric UUID"; | |
| private final String HEADER_CONCEPT_NUMERIC_UUID = "Concept numeric uuid"; |
api-2.7/pom.xml
Outdated
| <artifactId>initializer</artifactId> | ||
| <groupId>org.openmrs.module</groupId> |
There was a problem hiding this comment.
nit: When referencing external modules, it should be Group-Artifact-Version.
Suggested change
| <artifactId>initializer</artifactId> | |
| <groupId>org.openmrs.module</groupId> | |
| <groupId>org.openmrs.module</groupId> | |
| <artifactId>initializer</artifactId> |
...va/org/openmrs/module/initializer/api/conceptreferencerange/ConceptReferenceRangeLoader.java
Outdated
Show resolved
Hide resolved
wikumChamith
force-pushed
the
TRUNK-6264
branch
from
150d3a1 to
d81fd6d
Compare
ibacher
reviewed
Jan 7, 2025
...org/openmrs/module/initializer/api/lineprocessor/ConceptReferenceRangeLineProcessorTest.java
Outdated
Show resolved
Hide resolved
wikumChamith
force-pushed
the
TRUNK-6264
branch
from
d81fd6d to
22c7299
Compare
wikumChamith
force-pushed
the
TRUNK-6264
branch
from
22c7299 to
469c510
Compare
|
@mks-d Any objection to merging this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for initializing concept reference ranges which was introduced in Platform 2.7.0