Skip to content

Fix: Prevent splitting of numbers and English words in Chinese text segmentation #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent splitting of numbers and English words in Chinese text segmentation #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions charabia/src/segmenter/chinese.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ fn cut_for_search<'a>(s: &'a str) -> Box<dyn Iterator<Item = &'a str> + 'a> {
if s.chars().count() <= 2 {
return Box::new(std::iter::once(s));
}
if s.chars().all(|c| c.is_ascii_alphanumeric()) {
return Box::new(std::iter::once(s));
}
let mut subwords = Vec::new();
let mut index = 0;
loop {
Expand Down Expand Up @@ -334,4 +337,11 @@ mod test {

// Macro that run several tests on the Segmenter.
test_segmenter!(ChineseSegmenter, TEXT, SEGMENTED, TOKENIZED, Script::Cj, Language::Cmn);

#[test]
fn test_mix_number_and_letter() {
let seg = ChineseSegmenter;
let words: Vec<&str> = seg.segment_str("我从2025年开始学习Rust语言。").collect();
assert_eq!(words, vec!["我", "从", "2025", "年", "开始", "学习", "Rust", "语言", "。"]);
}
}