Skip to content

Fix explode() null argument error in getFormattedAliases #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix explode() null argument error in getFormattedAliases #141

merged 1 commit into from
Jun 16, 2025

Conversation

mehrancodes
Copy link
Owner

Description

This PR fixes a PHP type error in ForgeService::getFormattedAliases() where explode() was being called with a null value.

Changes

  • Added null check for $this->setting->aliases before calling explode()
  • Returns an empty array when aliases is null or has not being set.

ref: #136 (comment)

@mehrancodes mehrancodes self-assigned this Jun 16, 2025
@mehrancodes mehrancodes merged commit 31b9953 into main Jun 16, 2025
1 check passed
@mehrancodes mehrancodes deleted the fix/handle-null-aliases-in-forge-service branch June 16, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mehrancodes mehrancodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mehrancodes