Fix #134: Add option to force delete and recreate existing database

[mehrancodes]

Overview

This PR fixes issue #134 by implementing a new RecreateDatabase action class that can optionally force delete existing databases and recreate them with new credentials.

Changes

• Created a new RecreateDatabase action class that encapsulates database recreation logic
• The action can check if a database exists, optionally delete it based on config, and recreate it
• Updated CreateDatabase pipeline to leverage the new action class
• Added PestPHP tests for the new RecreateDatabase action
• Added a forceDeleteOldDatabase flag to ForgeSetting to control this behavior

How to Test

Scenario 1: Existing database with force delete enabled

When you have an existing database on the server with the same name:

1. Set FORCE_DELETE_OLD_DATABASE=true in your .env file
2. Run Harbor provision to create a site
3. Expected behavior:
   • Harbor deletes the existing database
   • Harbor deletes any existing database user with the same name
   • A new database is created with the same name but new credentials

Scenario 2: Existing database with force delete disabled

When you have an existing database on the server with the same name:

1. Set FORCE_DELETE_OLD_DATABASE=false in your .env file (or leave it unset)
2. Run Harbor to create a site
3. Expected behavior:
   • Harbor preserves the existing database
   • Harbor displays a warning about the existing database
   • No new database is created

Scenario 3: No existing database

When no database exists with the specified name:

1. Run Harbor to create a site (regardless of FORCE_DELETE_OLD_DATABASE setting)
2. Expected behavior:
   • A new database is created with the specified name
   • New database credentials are set in the site's .env file

Fixes #134

[Copilot]

Pull Request Overview

This PR introduces a new mechanism to optionally force-delete and recreate existing databases when provisioning a site.

• Adds a dedicated RecreateDatabase action to encapsulate recreating logic and integrates it into the database creation pipeline
• Introduces a force_delete_old_database flag in settings and config to control deletion behavior
• Updates tests to cover both force-delete and non-force-delete scenarios

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
app/Services/Forge/Actions/RecreateDatabase.php	New action class handling optional deletion and recreation of databases
app/Services/Forge/Pipeline/CreateDatabase.php	Updated pipeline to use the new action and removed old helpers
app/Services/Forge/ForgeSetting.php	Added forceDeleteOldDatabase property and validation
config/forge.php	Exposed force_delete_old_database via environment
tests/Unit/Services/Forge/Actions/RecreateDatabaseTest.php	Added tests for force-delete and non-force-delete paths
.github/workflows/run-tests.yml	Bumped cache action to v4

Comments suppressed due to low confidence (2)

app/Services/Forge/Pipeline/CreateDatabase.php:40

• The Str class is used but not imported. Add use Illuminate\Support\Str; at the top of the file to avoid a class not found error.

$dbPassword = Str::random(16);

tests/Unit/Services/Forge/Actions/RecreateDatabaseTest.php:115

• The forceDeleteOldDatabase flag isn’t explicitly set in this test, so its default (null) may lead to unexpected behavior. Set it to false or true for clarity.

$this->service->setting = $this->settingMock;