Trying to fix build error on check repo #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiosba
requested review from
danielevalverde
and removed request for
computermacgyver and
dmou
danielevalverde
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
Thanks, @caiosba. This change appears to have resolved the Alegre build issue on the Check repository.
Before your changes, the build was consistently hanging during the pip install step for Alegre and queue_worker and now this step was completed without interruption
#88 [queue_worker 9/11] RUN pip install --no-cache-dir -r requirements.txt #88 DONE 290.8s #136 [alegre 9/11] RUN pip install --no-cache-dir -r requirements.txt
Log here: https://github.com/meedan/check/actions/runs/16757125892/job/47442589617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
checkbuild was installing a different version oftokenizer, despite the pinned version inrequirements.txt(maybe it was coming from another dependency). That different version was triggering an error oncheck's CI. This PR ensures that the version we need is installed.I also took the opportunity to fix some failing tests.
Reference: CV2-6381.