Don't start model servers on live. #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Check API side, all requests are routed to Presto, so we don't need to have the Alegre model servers running, as they are already managed by Presto. Reference: CV2-6259.
|
@sonoransun can you please confirm this is all we need to NOT start the model services on deployment, for both QA and live? |
We'll also need to turn down the instance counts, but that can be done when ready. |
caiosba
deleted the
request/CV2-6259-dont-start-model-servers-on-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the Check API side, all requests are routed to Presto, so we don't need to have the Alegre model servers running, as they are already managed by Presto.
Reference: CV2-6259.
How has this been tested?
After deployment, we need to make sure that the Alegre model services don't start.
Have you considered secure coding practices when writing this code?
N/A.