Cv2 5605 run alegre tests in GitHub actions #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinelo-obitube
requested review from
DGaffney,
computermacgyver and
skyemeedan
as code owners
chinelo-obitube
changed the title
skyemeedan
reviewed
Nov 7, 2024
skyemeedan
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
This looks good to me, @DGaffney is this an OK time to switcher from Travis to Github?
dmou
reviewed
Nov 21, 2024
.github/workflows/ci-tests.yaml
Outdated
| branches: | ||
| - master | ||
| - develop | ||
| - "**" |
There was a problem hiding this comment.
q: intentional to run all alegre tests on every commit?
There was a problem hiding this comment.
Thats right. it is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to migrate alegre tests from Travis to Github Actions.
Reference: (https://meedan.atlassian.net/browse/CV2-5604)
How has this been tested?
Has it been tested locally? Are there automated tests?
Have you considered secure coding practices when writing this code?
I have a question related to codeclimate, I see the code climate file and will add it here.