Skip to content

CV2-5050 fix for null reference error on language resolution #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2024
Merged

CV2-5050 fix for null reference error on language resolution #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60721fa
CV2-5050 fix for null reference error on language resolution
DGaffney Nov 4, 2024
3b8a6ca
add test coverage for null events
DGaffney Nov 4, 2024
6962ccd
fix typo
DGaffney Nov 4, 2024
7416be4
flesh out error expectation
DGaffney Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/main/lib/langid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def langid(text):
prediction = cld3.get_language(text)
return {
'result': {
'language': prediction.language,
'confidence': prediction.probability
'language': prediction and prediction.language,
'confidence': prediction and prediction.probability
},
'raw': prediction,
'model': 'CLD3',
Expand Down
13 changes: 13 additions & 0 deletions app/test/test_langid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,19 @@ def test_langid_api_get_without_text(self):
self.assertEqual('application/json', response.content_type)
self.assertEqual(200, response.status_code)

def test_null_prediction_cld(self):
with patch('cld3.get_language', ) as mock_cld3_get_language:
mock_cld3_get_language.return_value = None
expected = {
'result': {
'language': None,
'confidence': None
},
'raw': None,
'model': 'CLD3',
}
self.assertEqual(Cld3LangidProvider.langid("foo bar"), {'model': 'CLD3', 'raw': None, 'result': {'confidence': None, 'language': None}})

def test_langid_api_post(self):
response = self.client.post(
'/text/langid/',
Expand Down
Loading