CV2-5399 downgrade a bunch of info logs to debug, gut some logs, refactor others for consistency #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor others for consistency
DGaffney
requested review from
computermacgyver and
skyemeedan
as code owners
DGaffney
requested review from
caiosba and
computermacgyver
and removed request for
computermacgyver and
skyemeedan
|
a lot of these seem like they really are debug logs (i.e. logging out full data of request) which will make logs really big and verbose in the long term. For short term debugging, would it be easier to temporarily change the log level to DEBUG where it is deployed? |
Honestly at this point my preference is to just delete all these - @caiosba / @computermacgyver lmk what you think. @skyemeedan as it stands these are creating really big verbose logs already |
ahmednasserswe
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up overly verbose logs - changes nothing about the execution of code itself!
Reference: CV2-5399
How has this been tested?
Not tested locally, only change that may have an impact is missing references if new/shifted logs are in places where vars aren't, I don't think we have any of those though!
Have you considered secure coding practices when writing this code?
None