Skip to content

fix automated release issue #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix automated release issue #106

merged 1 commit into from
Jun 11, 2025

Conversation

rahulbot
Copy link
Contributor

Right now we can't do automated releases, because of the error described in #105 . The suggested fix is to upgrade to actions/upload-artifact@v4.6.2. Curious that the bot didn't suggest this alongside the fix for download-artifact (#93).

I gave the migration guide and it doesn't look like any of the breaking changes impact our usage, but this definitely needs another pair of eyes reading to verify: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Also is there any way to test this automation against just the test deploy server? Or do we have to just push a real tag and have it build a real release?

@rahulbot rahulbot requested review from pgulley and philbudne June 10, 2025 16:38
@rahulbot rahulbot added the bug label Jun 10, 2025
Copy link
Contributor

@philbudne philbudne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue about github ci integrations, so looks OK to me!

I'm not a fan of whitespace changes (since it obscures who is to blame), BUT I also hate trailing whitespace, and the lines are trivial, so.... APPROVED!

@rahulbot
Copy link
Contributor Author

rahulbot commented Jun 10, 2025

FYI: the automated pre-commit hooks listing made all the whitespace changes automatically. Not sure how they got in there in the first place... maybe someone didn't have the hooks set up?:

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check json...........................................(no files to check)Skipped
check toml...........................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
isort (python).......................................(no files to check)Skipped

@rahulbot
Copy link
Contributor Author

I guess I'll merge and try it with a real tag 🤞🏽

@rahulbot rahulbot closed this Jun 11, 2025
@rahulbot rahulbot reopened this Jun 11, 2025
@rahulbot rahulbot merged commit 0e7c99e into main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants