Skip to content

Book detail - stop escaping already escaped title/summary #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Book detail - stop escaping already escaped title/summary #305

merged 1 commit into from
Mar 21, 2025

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Mar 17, 2025 •
edited
Loading

This is the demo side fix to mdn/content#5320

I'm unescaping the displayed data, which is escaped already by the code that validates form data

@hamishwillee hamishwillee requested a review from bsmth as a code owner March 17, 2025 00:25
@Josh-Cena Josh-Cena mentioned this pull request Mar 17, 2025
Merged
bsmth
bsmth approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve to unblock. One thing is that on http://localhost:3000/catalog/books, if you add a book title with " in there, you will see

the "book" title

Do you think that's expected? Otherwise, looking good!

@hamishwillee
Copy link
Collaborator Author

Do you think that's expected? Otherwise, looking good!

@bsmth Yoiks. No, not expected. Thank you. Fixed now.

@hamishwillee hamishwillee merged commit 9f7e8e6 into mdn:main Mar 21, 2025
3 checks passed
@hamishwillee hamishwillee deleted the unescape_templates branch March 21, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @bsmth