Skip to content

feat(mirror): ignore OS limitations when mirroring to mobile #28226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(mirror): ignore OS limitations when mirroring to mobile #28226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4efd652
feat(mirror): ignore OS limitations when mirroring to mobile
caugner Oct 17, 2025
36be133
Run `npm run lint:fix`
caugner Oct 17, 2025
52d41d0
Merge branch 'main' into ignore-os-limitations-when-mirroring-to-mobile
caugner Oct 28, 2025
0199816
fixup! feat(mirror): ignore OS limitations when mirroring to mobile
caugner Oct 28, 2025
94e67e4
Run `npm run fix` once
caugner Oct 28, 2025
fae96c8
Merge branch 'main' into ignore-os-limitations-when-mirroring-to-mobile
caugner Nov 4, 2025
9815f15
Run `npm run lint:fix`
caugner Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions api/GPUAdapter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "127"
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": "141",
Expand Down Expand Up @@ -437,9 +435,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "133"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
24 changes: 6 additions & 18 deletions api/GPUCommandEncoder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -226,9 +224,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "140"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -268,9 +264,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "125"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -309,9 +303,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "123"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -351,9 +343,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -508,9 +498,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "137"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
32 changes: 8 additions & 24 deletions api/GPUDevice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "138"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -208,9 +206,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "140"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -249,9 +245,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "137"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -801,9 +795,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "135"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -901,9 +893,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -1059,9 +1049,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "130"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -1362,9 +1350,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "130"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -1984,9 +1970,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
4 changes: 1 addition & 3 deletions api/GPUQuerySet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "121"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
8 changes: 2 additions & 6 deletions api/GPUSupportedFeatures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,9 +862,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "142"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down Expand Up @@ -904,9 +902,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "142"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
4 changes: 1 addition & 3 deletions api/GPUTexture.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@
"partial_implementation": true,
"notes": "Supported on ChromeOS, macOS, and Windows only."
},
"chrome_android": {
"version_added": "132"
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
Expand Down
64 changes: 63 additions & 1 deletion scripts/build/mirror.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,39 @@ import { BrowserName } from '../../types/types.js';
import bcd from '../../index.js';
import { InternalSupportBlock } from '../../types/index.js';

import mirrorSupport from './mirror.js';
import mirrorSupport, { isOSLimitation } from './mirror.js';

describe('mirror', () => {
describe('isOSLimitation', () => {
it('returns true for OS limitation notes', () => {
assert.equal(
isOSLimitation('Supported on ChromeOS, macOS, and Windows only.'),
true,
);
assert.equal(isOSLimitation('Supported on macOS only.'), true);
assert.equal(isOSLimitation('Not supported on Windows.'), true);
});

it('returns false for non-OS-limitation notes', () => {
assert.equal(
isOSLimitation('This feature requires a flag to be enabled.'),
false,
);
assert.equal(
isOSLimitation('Before version 70, this method always returned true.'),
false,
);
assert.equal(
isOSLimitation('Firefox 73 added support for this thing.'),
false,
);
});

it('returns false for empty string', () => {
assert.equal(isOSLimitation(''), false);
});
});

describe('default export', () => {
describe('version numbers match expected values', () => {
const mappings: {
Expand Down Expand Up @@ -189,6 +219,38 @@ describe('mirror', () => {
notes: 'This feature is only supported in ChromeOS, macOS and Linux.',
});
});

it('OS-specific partial_implementation and notes are not mirrored', () => {
const support = {
chrome: {
version_added: '134',
partial_implementation: true,
notes: 'Supported on ChromeOS, macOS, and Windows only.',
},
};

const mirrored = mirrorSupport('chrome_android', support);
assert.deepEqual(mirrored, {
version_added: '134',
});
});

it('Non-OS-specific partial_implementation and notes are still mirrored', () => {
const support = {
chrome: {
version_added: '70',
partial_implementation: true,
notes: 'This feature is incomplete and may not work as expected.',
},
};

const mirrored = mirrorSupport('chrome_android', support);
assert.deepEqual(mirrored, {
version_added: '70',
partial_implementation: true,
notes: 'This feature is incomplete and may not work as expected.',
});
});
});

describe('Validations', () => {
Expand Down
57 changes: 56 additions & 1 deletion scripts/build/mirror.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,38 @@ const { browsers } = bcd;

type Notes = string | [string, string, ...string[]] | null;

const OS_NOTES = [
'Available on macOS and Windows only.',
'Available only on macOS.',
'ChromeOS only',
'ChromeOS and Windows',
'Fully supported on Windows and Linux, no support on ChromeOS.',
'Linux support is not enabled by default.',
'Not supported on macOS.',
'Not supported on Windows.',
'Only on macOS and Windows.',
'Only on Windows.',
'Only supported on ChromeOS',
'Only supported on macOS.',
'Only supported on Windows.',
'Only works on macOS.',
'Supported on ChromeOS, macOS, and Windows only.',
'Supported on ChromeOS and macOS only.',
'Supported on macOS only.',
'Supported on macOS Catalina 10.15.1+, Windows, and ChromeOS. Not yet supported on Linux.',
'Supported on Windows only, in all contexts except for service workers.',
'Supported only on macOS 10.12 (Sierra) and later.',
'This cursor is only supported on macOS and Linux.',
].map((s) => s.toLowerCase());

/**
* Check if a note indicates OS-specific limitations.
* @param notes A single notes string from a support statement
* @returns True if the notes indicate OS-specific limitations
*/
export const isOSLimitation = (notes: string): boolean => {
return OS_NOTES.includes(notes.toLowerCase());
};

const matchingSafariVersions = new Map([
['1', '1'],
Expand Down Expand Up @@ -215,6 +245,30 @@ export const bumpSupport = (

const newData: SimpleSupportStatement = copyStatement(sourceData);

if (
browsers[sourceBrowser].type === 'desktop' &&
browsers[destination].type === 'mobile' &&
sourceData.partial_implementation
) {
const notes = Array.isArray(sourceData.notes)
? sourceData.notes
: sourceData.notes
? [sourceData.notes]
: [];
const [firstNote, secondNote, ...otherNotes] = notes.filter(
(notes) => !isOSLimitation(notes),
);
if (!firstNote) {
// Ignore OS limitation.
delete newData.partial_implementation;
delete newData.notes;
} else if (!secondNote) {
newData.notes = firstNote;
} else {
newData.notes = [firstNote, secondNote, ...otherNotes];
}
}

if (!browsers[destination].accepts_flags && newData.flags) {
// Remove flag data if the target browser doesn't accept flags
return { version_added: false };
Expand Down Expand Up @@ -254,7 +308,8 @@ export const bumpSupport = (
return { version_added: false };
}

if (sourceData.notes) {
// Only process notes if they weren't already removed (e.g., for OS-specific limitations)
if (sourceData.notes && newData.notes !== undefined) {
const sourceBrowserName =
sourceBrowser === 'chrome'
? '(Google )?Chrome'
Expand Down