Skip to content

Add APIs from the Explicit Resource Management #27386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pepelsbey
Copy link
Member

Summary

This goes along with the MDN content PR by @Josh-Cena.

⚠️ The seven new features added in this PR are missing the support info. This would be better added via collector.

Test results and supporting details

[To be added]

Related issues

@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:m [PR only] 25-100 LoC changed labels Jul 23, 2025
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@pepelsbey
Copy link
Member Author

@Josh-Cena, could you please have a quick look if everything is in order here? All features you have documented are present, and the links to the spec are correct. Thanks!

@Elchi3 I was hoping to get the support data for the new features from the collector run if possible. Could you please help with that? Thank you.

@Elchi3
Copy link
Member

Elchi3 commented Jul 24, 2025

Unfortunately, the collector doesn't yet know automatically about things coming from ECMAScript proposals (tracked in openwebdocs/mdn-bcd-collector#893). I opened openwebdocs/mdn-bcd-collector#2589 for the missing pieces.

@Josh-Cena
Copy link
Member

Stuff here look pretty good to me

@Elchi3
Copy link
Member

Elchi3 commented Jul 29, 2025

For Firefox 141 and Chrome 134 these are supported:

  • javascript.builtins.AsyncDisposableStack.@@asyncDispose
  • javascript.builtins.AsyncIterator.@@asyncDispose
  • javascript.builtins.DisposableStack.@@dispose
  • javascript.builtins.Iterator.@@dispose

No support in any browser so you shouldn't add these.

  • javascript.builtins.SuppressedError.error
  • javascript.builtins.SuppressedError.suppressed

@Josh-Cena
Copy link
Member

It's not possible for ERM to be supported without the two properties you mentioned

image

@Elchi3
Copy link
Member

Elchi3 commented Jul 29, 2025

It's not possible for ERM to be supported without the two properties you mentioned

Ah thanks, then the collector tests I added are wrong. Will look into it.

To move this PR forward, I would then assume same support for the new entries you're adding.

@pepelsbey
Copy link
Member Author

To move this PR forward, I would then assume same support for the new entries you're adding.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants