Bug-1828220 add browser_action.onUserSettingsChanged event #27355
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
gregorypappas
suggested changes
Jul 22, 2025
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": false |
There was a problem hiding this comment.
Chrome added this event in version 130
https://developer.chrome.com/docs/extensions/whats-new#chrome_130_actiononusersettingschanged
There was a problem hiding this comment.
Chrome supports it in the action namespace only, not browserAction:
- https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/extensions/api/action.json;l=409;drc=636dcb39ff241e388b9e4b1ce45ecf656bf0ec77
- https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/extensions/api/browser_action.json;drc=636dcb39ff241e388b9e4b1ce45ecf656bf0ec77
Firefox supports it in both.
webextensions/api/browserAction.json
Outdated
| }, | ||
| "firefox_android": { | ||
| "version_added": "142", | ||
| "notes": "Never fires as extensions can't be pinned to the bookmarks toolbar in Firefox for Android." |
There was a problem hiding this comment.
I suggest simplifying this statement. It currently implies that Firefox for Android has a bookmarks toolbar that extensions can't be pinned to. At the moment, Firefox for Android does not have a bookmarks toolbar at all.
github-actions
bot
added
size:m
gregorypappas
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds details for the addition of the
browser_action.onUserSettingsChangedevent. Addresses the dev-doc-needed requirements of Bug 1828220 Implement onUserSettingsChanged event.Related issues
See mdn/content#40488 for details of the documentation changes.